Re: [PATCH] Blackfin BF54x NAND Flash Controller driver

[Andrew Morton]

On Thu, 13 Sep 2007 04:45:13 -0400 "Mike Frysinger" <vapier.adi@xxxxxxxxx> wrote:

> On 9/13/07, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, 03 Sep 2007 15:25:23 +0800 Bryan Wu <bryan.wu@xxxxxxxxxx> wrote:
> > > This is the driver for latest Blackfin BF54x nand flash controller
> > >
> > >  - use nand_chip and mtd_info common nand driver interface
> > >  - provide both PIO and dma operation
> > >  - compiled with ezkit bf548 configuration
> > >  - use hardware 1-bit ECC
> > >  - tested with YAFFS2 and can mount YAFFS2 filesystem as rootfs
> > >
> > > ...
> > >
> > > +int hardware_ecc = 0;
> >
> > scripts/checkpatch.pl, please.
> 
> that isnt static so checkpatch.pl wouldnt have caught it ...

box:/usr/src/25> perl scripts/checkpatch.pl ~/x
ERROR: do not initialise externals to 0 or NULL
#186: FILE: drivers/mtd/nand/bf54x_nand.c:73:
+int hardware_ecc = 0;

> it should be static though of course

good point.

> and then checkpatch.pl would have thrown a
> static init 0 warning :)
> -mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/