Re: [PATCH] add CONFIG_VT_UNICODE

[H. Peter Anvin]

Jan Engelhardt wrote:
> On Aug 31 2007 16:18, Bill Nottingham wrote:
>> As of now, the kernel defaults to non-unicode and XLATE for the keyboard.
>> We've been changing this in Fedora, but that requires patching the defaults
>> in the kernel.
>>
>> The attached introduces CONFIG_VT_UNICODE, which sets the console in unicode
>> mode by default on boot, including both the virtual terminal and the keyboard
>> driver.
> 
> I would prefer to:
>  - make default_utf=1 in the source
>  - add "default_utf8 ? VC_UNICODE : VC_XLATE" to the keyboard code
>    as your patch does
>  - and do away with the new CONFIG_ option, since, surprise, surprise,
>    you can change it at runtime, so there is no need to do it
>    at compile-time too.
> 

I concur.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/