Re: [patch] update CFI URI n mtd kconfig

[Josh Boyer]

On 9/13/07, Robin Getz <rgetz@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu 13 Sep 2007 14:28, Josh Boyer pondered:
> > On 9/12/07, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> > > Since AMD shunted its flash memory division, the URI in the mtd Kconfig is now
> > > broken, so the attached patch points people to Wikipedia.
> > >
> > > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> > > ---
> > > diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
> > > index 479d32b..980117a 100644
> > > --- a/drivers/mtd/chips/Kconfig
> > > +++ b/drivers/mtd/chips/Kconfig
> > > @@ -11,8 +11,8 @@ config MTD_CFI
> > >           AMD and other flash manufactures that provides a universal method
>
> Even on the Intel page, it gives "Intel, AMD, Sharp, and Fujitsu" credit - why
> limit Sharp, and Fujitsu to "others"? (I would just take out everyone's name).

He wasn't changing that part of the option.  I'm fairly certain that
description has been there for years.  If you want to change it to be
a bit more "fair", feel free.

> > >           for probing the capabilities of flash devices. If you wish to
> > >           support any device that is CFI-compliant, you need to enable this
> > > -         option. Visit <http://www.amd.com/products/nvd/overview/cfi.html>
> > > -         for more information on CFI.
> > > +         option. For more information on CFI, visit:
> > > +         <http://wikipedia.org/wiki/Common_Flash_Memory_Interface>
> >
> > Erm, I'd rather not point to wikipedia.  Can you change it to point to:
> >
> > http://www.intel.com/design/flash/swb/cfi.htm
>
> Why not from the place that you can get the standard? http://jedec.org/
>
> or http://www.jedec.org/download/search/jesd68-01.pdf
>
> There isn't any point to pick one vendor - unless you work there, own
> stock, or one provides outstanding support (free hardware) for driver
> development. :)

I wasn't picking a vendor.  I was pointing out a well laid out webpage
that describes what CFI is and provides the spec for it.  If you want
to link directly to jedec, ok.

And no, I don't work at Intel, own stock in it, or know of them giving
out free hardware on a regular basis.  I do happen to like what Intel
is doing in regards to opening their drivers, but that has nothing to
do with this :).

josh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/