Re: Driver core: remove get_bus()

From: Greg KH
Date: Fri Sep 14 2007 - 10:34:36 EST


On Fri, Sep 14, 2007 at 01:02:07PM +0200, Cornelia Huck wrote:
> On Thu, 13 Sep 2007 16:38:50 -0700,
> Greg KH <greg@xxxxxxxxx> wrote:
>
> > get_bus() should not be globally visable as it is not used by anything
> > other than drivers/base/bus.c. This patch removes the visability of it,
>
> Makes sense.
>
> > and renames it to match all of the other *_get() functions in the
> > kernel.
>
> What about get_device() and get_driver()? (Not that I want to change
> those, but I think the driver core should stick to one naming
> convention.)

Yes, we should stick to one convention, that's why I made these changes.
Also they were self-contained, as you mention, it would be much harder
to change get_device :(

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/