Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used asa module. Works as a module.

[Eric Valette]

Paul Rolland (ããããããã) wrote:
> Hi Eric,

>> Now I have two side questions:
>> 	- the code is no more symetric "subsys_initcall" -> "module_exit".
>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>> it still works as a module...
> Symmetry is not broken, as we have :
> #define subsys_initcall(fn)             module_init(fn)
> in include/linux/init.h where compiling as a module, and when not compiling
> as a module, I doubt the exit function is called unless you are shuting
> down your machine...

I came to this conclusion too. But I would have preferred to have
#define subsys_exit(fn)			modules_exit(fn)

in the case of a module and nop in the non module case...


-- eric





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/