[PATCH] cifs: Fix a small memory leak in directory creation code.

[Jesper Juhl]

There is a small memory leak in fs/cifs/inode.c::cifs_mkdir().
Storage for 'pInfo' is allocated with kzalloc(), but if the call  
to CIFSPOSIXCreate(...) happens to return 0 and pInfo->Type == -1, 
then we'll jump to the 'mkdir_get_info' label without freeing the 
storage allocated for 'pInfo'.
This patch adds a kfree() call to free the storage just before 
jumping to the label, thus getting rid of the leak.


Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
---

 inode.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6/fs/cifs/inode.c~	2007-09-16 23:01:52.000000000 +0200
+++ linux-2.6/fs/cifs/inode.c	2007-09-16 23:01:52.000000000 +0200
@@ -929,8 +929,10 @@ int cifs_mkdir(struct inode *inode, stru
 			d_drop(direntry);
 		} else {
 			int obj_type;
-			if (pInfo->Type == -1) /* no return info - go query */
+			if (pInfo->Type == -1) { /* no return info - go query */
+				kfree(pInfo);
 				goto mkdir_get_info;
+			}
 /*BB check (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID ) to see if need
 	to set uid/gid */
 			inc_nlink(inode);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/