On Tuesday 18 September 2007 04:19, Avi Kivity wrote:
Nick Piggin wrote:
In kvm I don't add compatibility #ifdefs to mainline, instead I have anI should mention that the converting to use ->fault() is a 15-minuteIt should be mostly possible to ifdef a nopage() handler, which is
change; the tricky part is adding backwards compatibility for the
external module package.
just a wrapper function to translate arguments then call your new
->fault() handler. With luck, fault would mostly inline into nopage,
and do some constant folding to make it cheaper...
I'm planning to go through and convert the rest of the in-tree users
at some point soon, so if you do get a chance to convert your
upstream code before I try, it would nice ;)
awk script that massages the sources into something that all kernels can
grok.
Sure, but my suggestion is just a way to make it possible without having
to maintain a lot of duplicated code. The point is simply that we'll be
getting rid of nopage from mainline sooner or later, and it will probably
be less painful for your out of tree stuff if you do it rather than me. Maybe.