Re: [TOMOYO 05/15](repost) Domain transition handler functions.

[James Morris]

On Tue, 2 Oct 2007, Kentaro Takeda wrote:

> +
> +	mb(); /* Instead of using spinlock. */
> +	ptr = domain_initializer_list;
> +	if (ptr) {
> +		while (ptr->next)
> +			ptr = ptr->next;
> +		ptr->next = new_entry;
> +	} else
> +		domain_initializer_list = new_entry;
> +

Please use standard kernel list handling, per include/linux/list.h

Why do you need to avoid spinlocks for these manipulations?



- James
-- 
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/