Re: [PATCH] missing include in mmc

From: David Brownell
Date: Tue Oct 16 2007 - 23:21:52 EST


> > > AFAICS, fallout from repacing include of blkdev.h with include of bio.h.
> >
> > Out of curiousity, which architecture(s) need this?
>
> Umm... IIRC, m32r had been the first build to step into that, at which point
> the missing include had been added; the rest had reached that point later, so
> I'm not sure which ones would trigger the same crap. Not hard to test,
> though...
>
> Aha. m68k as well.

FWIW this driver originally started out on ColdFire (m68k derived),
a few years back. :)

Every time I seee a case where architectures don't act the same
with respect to #includes, I count it as an unpleasant surprise.
Not one that's very easy to avoid, unfortunately, but I think it's
been happening less often lately.

Thanks for the fix.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/