Re: [PATCH] [275/2many] MAINTAINERS - KDUMP

[Joe Perches]

On Wed, 2007-10-17 at 12:48 +0900, Simon Horman wrote:
> Do you have a criteria for including files.

A file or file pattern specific to a maintained "subsystem".

Any time a subsystem file pattern matches a file,
maintainers would be cc'd.  The matching is non-exclusive.
Multiple subsystems can include the same file pattern.

For KDUMP, maybe a file pattern should be:

F:	arch/*/kernel/crash_dump.c
F:	include/linux/crash_dump.h

> Are they files that only apply to KEXEC/KDUMP,
> or files that have KEXEC/KDUMP code and other code?

I think it should be files specific to KDUMP and not
files shared with other subsystems but perhaps it's
maintainer taste.

If the files patterns are not specific to kdump,
the kdump maintainers will be cc'd on patches that
change files where kdump functions aren't modified.

The list of files that include crash_dump.h is pretty long.

        $ grep -P -l -r --include=*.[ch] crash_dump.h *
        arch/i386/kernel/crash_dump.c
        arch/i386/kernel/setup.c
        arch/ia64/hp/common/sba_iommu.c
        arch/ia64/kernel/crash.c
        arch/ia64/kernel/setup.c
        arch/powerpc/kernel/crash.c
        arch/powerpc/kernel/crash_dump.c
        arch/sh/kernel/crash_dump.c
        arch/x86_64/kernel/crash_dump.c
        arch/x86_64/kernel/setup.c
        drivers/char/mem.c
        fs/proc/proc_misc.c
        fs/proc/vmcore.c
        
The list of files that use CONFIG_CRASH_DUMP is also
pretty long and seemingly unrelated.

        $ grep -P -l -r --include=*.[ch] CONFIG_CRASH_DUMP *
        arch/i386/kernel/apic.c
        arch/i386/kernel/e820.c
        arch/ia64/hp/common/sba_iommu.c
        arch/ia64/kernel/efi.c
        arch/powerpc/kernel/iommu.c
        arch/powerpc/platforms/cell/ras.c
        arch/powerpc/platforms/pseries/iommu.c
        arch/x86_64/kernel/e820.c
        drivers/char/mem.c
        include/asm-powerpc/kdump.h
        include/linux/bootmem.h
        include/linux/crash_dump.h
        mm/bootmem.c



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/