Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate

From: Alan Cox
Date: Wed Oct 17 2007 - 06:40:41 EST


On Tue, 16 Oct 2007 19:12:11 +0100 (BST)
"Maciej W. Rozycki" <macro@xxxxxxxxxxxxxx> wrote:

> The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
> a problem with the baud_table within. The comparison operators are
> reversed and as a result this table's entries never match and BOTHER is
> always used.

Oops. I thought I'd fixed that one. Bit bothersome its been in -mm that
long before anyone noticed.

ACK the first bit.

> Additionally this function's prototype is not exported unlike the
> function itself.

That bit seems out of date and a prototype was added later in -mm

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/