Re: [PATCH 0/3] Fix two PEIe hotplug issues

[Kristen Carlson Accardi]

On Wed, 17 Oct 2007 23:09:45 -0400
Mark Lord <lkml@xxxxxx> wrote:

> Mark Lord wrote:
> > Fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks
> > (and others?) in conjunction with the modparam of pciehp_force=1.
> 
> 
> To make things simpler for distro people, I'm contemplating another patch
> in this series, to allow something like:  pciehp_force=2
> 
> This would then *try* the ACPI BIOS calls, and only fall back to pcie_force=1
> if the BIOS support fails.  This would be an ideal default for most desktop/notebook
> distros to consider using.
> 
> Without this, they don't have any good choice:  use the defaults, and things fail
> on the most popular brand of machines in the marketplace.  Use pciehp_force=1,
> and they may break (?) on other brands.
> 
> So a hybrid of the two seems best.  Pity it couldn't be the default behaviour, though.
> Or could it?  We're early enough in the 2.6.24 cycle for it..
> 
> Opinions?
> 

NAK!  Absolutely no way will I take a patch that does this.  
I've been actually having philosophical issues with
even having pciehp_force as a module parameter at all.  As I said before,
using pciehp_force violates the PCI spec.  Vendors often deliberately 
do not support OSC due to hardware errata.  Users who use this option risk
breaking their laptop.  I was thinking actually that we should make it
more difficult to use this option, like make it a compile time option,
or perhaps rename it to this_could_seriously_break_your_hardware_dont_use.

Probably we shouldn't have the functionality in the driver at all, but
I don't really want to take it out all together, because it's handy for those
of us who work on early hardware, where we can ask the BIOS people why
they didn't implement OSC, and then consciously force it knowing exactly
what we are doing and the potential consequences.  But, maybe we should
consider the possibility that we should remove the code so as to really
really prevent distros from using this option.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/