Re: Locking problem in usbserial with 2.6.23-git 5a34417f

[Larry Finger]

Jiri Kosina wrote:
> On Fri, 19 Oct 2007, Larry Finger wrote:
> 
>> As I said earlier, the lock problem went away; however, I get the 
>> following two kernel warnings:
> 
> That's because I messed up the patch, sorry. The one below should work 
> better.
> 
> 
> 
> From: Jiri Kosina <jkosina@xxxxxxx>
> 
> USB: usbserial - fix potential deadlock between write() and IRQ
> 
> usb_serial_generic_write() doesn't disable interrupts when taking port->lock,
> and could therefore deadlock with usb_serial_generic_read_bulk_callback()
> being called from interrupt, taking the same lock. Fix it.
> 
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

It does work better. With it, I was able to make a dial-up connection and send pings over it.

Larry

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/