Re: [PATCH 8/17] arch/x86/kernel/vm86_32.c: irq handler cleanup

[Thomas Gleixner]

On Sun, 21 Oct 2007, Jeff Garzik wrote:

> commit f57c82aa01f4387c8400acb43afa7fc580635e16
> Author: Jeff Garzik <jeff@xxxxxxxxxx>
> Date:   Fri Oct 19 19:25:42 2007 -0400
> 
>     arch/x86/kernel/vm86_32.c: irq handler cleanup
>     
>     Obtain the data we want (irq number) via dev_id.
>     
>     Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
> 
>  arch/x86/kernel/vm86_32.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> f57c82aa01f4387c8400acb43afa7fc580635e16
> diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
> index 157e4be..336618b 100644
> --- a/arch/x86/kernel/vm86_32.c
> +++ b/arch/x86/kernel/vm86_32.c
> @@ -739,8 +739,9 @@ static int irqbits;
>  	| (1 << SIGUSR1) | (1 << SIGUSR2) | (1 << SIGIO)  | (1 << SIGURG) \
>  	| (1 << SIGUNUSED) )
>  	
> -static irqreturn_t irq_handler(int intno, void *dev_id)
> +static irqreturn_t irq_handler(int dummy, void *dev_id)
>  {
> +	int intno = (int)(unsigned long) dev_id;
>  	int irq_bit;

can we put the two ints into one line please. The typecast is ugly,
but looking into the file itself it does not really increase the
existing ugliness much.

	Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/