Re: [PATCH] unlock before bug returns

[Roel Kluin]

Roel Kluin wrote:

>     unlock before bug returns

>  	if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) {
>  		printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
> -		BUG();
>  		spin_unlock(&gpmc_mem_lock);
> -		return;
> +		BUG();


should we bother to unlock before panicking, or is the unlock not required either?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/