Re: [PATCH] m68k: Use cc-cross-prefix (was: Re: [GI:wqT PULL] kbuildupdates - second round)

[Geert Uytterhoeven]

On Mon, 22 Oct 2007, Andreas Schwab wrote:
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
> >> Did you mean to use $(SUBARCH) here?
>                          ^^^^^^^
> 
> > Oops, indeed. Sorry, here's a new one...

> > +ifneq ($(SUB_ARCH),$(ARCH))
>             ^^^^^^^^
> You did test it, didn't you?

Bummer, I only tested a cross-compile build, as I don't have access to a
native m68k machine at this moment. Third time, good time? I also added
m68k-unknown-linux-gnu- to please KolbjÃrn Barmen and the other Gentoo
people.
---

m68k: Use cc-cross-prefix

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---
 arch/m68k/Makefile |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

--- a/arch/m68k/Makefile
+++ b/arch/m68k/Makefile
@@ -13,16 +13,15 @@
 # Copyright (C) 1994 by Hamish Macdonald
 #
 
-# test for cross compiling
-COMPILE_ARCH = $(shell uname -m)
-
 # override top level makefile
 AS += -m68020
 LDFLAGS := -m m68kelf
 LDFLAGS_MODULE += -T $(srctree)/arch/m68k/kernel/module.lds
-ifneq ($(COMPILE_ARCH),$(ARCH))
-	# prefix for cross-compiling binaries
-	CROSS_COMPILE = m68k-linux-gnu-
+ifneq ($(SUBARCH),$(ARCH))
+	ifeq ($(CROSS_COMPILE),)
+		CROSS_COMPILE := $(call cc-cross-prefix, \
+			m68k-linux-gnu- m68k-linux- m68k-unknown-linux-gnu-)
+	endif
 endif
 
 ifdef CONFIG_SUN3

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds