Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix

From: Yinghai Lu
Date: Tue Oct 23 2007 - 01:36:33 EST


On 10/12/07, travis@xxxxxxx <travis@xxxxxxx> wrote:
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
>
> Signed-off-by: Mike Travis <travis@xxxxxxx>
> ---
> arch/x86_64/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
> struct cpuinfo_x86 *c = &cpu_data(id);
>
> *c = boot_cpu_data;
> - c->cpu_index = id;
> identify_cpu(c);
> + c->cpu_index = id;
> print_cpu_info(c);
> }
>

why not removing assignment in early_identify_cpu?

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/