Re: [PATCH -v7 1/3] x86 boot: setup data

[H. Peter Anvin]

Jeremy Fitzhardinge wrote:
> >  1:
> > +	movl boot_params - __PAGE_OFFSET + SETUP_DATA_POINTER,%ebp
>
> You need to check the boot protocol version before looking at this pointer.

No, he doesn't.  The boot protocol version is communication between the 
boot loader and the kernel (specifically, it is communication FROM the 
kernel TO the bootloader), not between internal bits of the kernel.  Th

Since the pointer is safely inside the setup template, even if the 
bootloader doesn't understand boot protocol version 2.08 it will have 
copied it.

So this is fine.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/