RE: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend>

[Mingarelli, Thomas]

We will never have more than one iLO2 device in a server so no multiple
instances are possible. 

Tom 

-----Original Message-----
From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] 
Sent: Tuesday, October 23, 2007 4:21 PM
To: Helgaas, Bjorn
Cc: Mingarelli, Thomas; linux-kernel@xxxxxxxxxxxxxxx; Wim Van Sebroeck
Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch
<resend>

On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote:
> The driver assumes only a single instance of the device.  But PCI 
> being what it is, it's often possible to have multiple cards, so you 
> might want some protection in case you trip over more than one.

Yes.  And even with that protection please move all the global variables
into some per-device structure.  That makes the code a lot more
understandable and future-proof in case multiple devices of this type
may appear somewhere.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/