Re: [PATCH 1/4] stringbuf: A string buffer implementation

From: Andrew Morton
Date: Tue Oct 23 2007 - 22:45:43 EST


On Tue, 23 Oct 2007 20:30:35 -0600 Matthew Wilcox <matthew@xxxxxx> wrote:

> It's a matter of taste ... some people prefer to use accessors for
> everything, other people prefer to expose the underlying structure
> directly.

Experience tells us that when you use accessors you end up thanking
yourself later on. Especially when diddling struct page ;)

Although one really should make a best-effort guess at "how likely is
this to change in the future". If the implementation-to-be-copied
has been out there for a while then "not very" is a good answer.

But hey, don't listen to me - I like C++, and approve of Java.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/