Re: [PATCH 2/12] X86: fix nvidia HPET warning

[Jeff Garzik]

Jeremy Fitzhardinge wrote:
> Jeff Garzik wrote:
> > arch/x86/kernel/early-quirks.c:40: warning: ânvidia_hpet_checkâ defined but not used
> >
> > Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
> > ---
> >
> > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> > index dc34acb..639e632 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -35,12 +35,14 @@ static void __init via_bugs(void)
> >  }
> >  
> >  #ifdef CONFIG_ACPI
> > +#ifdef CONFIG_X86_IO_APIC
> >   
>
> Why not #if defined(CONFIG_ACPI) && defined(CONFIG_X86_IO_APIC)?  Saves
> a line and a layer of #if(def).

quite agreed, but I was merely duplicating (with precision :)) the 
ifdef-ery used in the caller

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/