Re: [PATCH 4/12] riscom8: fix SMP brokenness

From: Andrew Morton
Date: Wed Oct 24 2007 - 04:00:56 EST


On Wed, 24 Oct 2007 09:44:07 +0200 Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> On 10/24/2007 09:10 AM, Andrew Morton wrote:
> > On Wed, 24 Oct 2007 08:47:23 +0200 Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> >
> >>> +static spinlock_t riscom_lock = SPIN_LOCK_UNLOCKED;
> >> This is deprecated (see linux/spinlock_types.h for details), use DEFINE_SPINLOCK
> >> instead, otherwise seems OK.
> >
> > Hey, if only we had a little perl script to check stuff like that.
>
> Can we integrate this into checkpatch?

We already did.

Now we need to integrate checkpatch into git...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/