[patch] kvm: fix !SMP build error

From: Ingo Molnar
Date: Wed Oct 24 2007 - 08:33:31 EST



* Avi Kivity <avi@xxxxxxxxxxxx> wrote:

> Of course SMP is not required. I'll submit a patch to make
> smp_call_function_mask() available on UP kernels. Andrew, please
> don't apply the KVM Kconfig patch.

i have triggered this and fixed it the right way - see the patch below.
This fixes the 2.6.24-rc1 build error.

Ingo

------------------->
Subject: kvm: fix !SMP build error
From: Ingo Molnar <mingo@xxxxxxx>

fix !SMP build error:

drivers/kvm/kvm_main.c: In function 'kvm_flush_remote_tlbs':
drivers/kvm/kvm_main.c:220: error: implicit declaration of function 'smp_call_function_mask'

(and also avoid unused function warning related to up_smp_call_function()
not making use of the 'func' parameter.)

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
include/linux/smp.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Index: linux/include/linux/smp.h
===================================================================
--- linux.orig/include/linux/smp.h
+++ linux/include/linux/smp.h
@@ -84,11 +84,12 @@ void smp_prepare_boot_cpu(void);
* These macros fold the SMP functionality into a single CPU system
*/
#define raw_smp_processor_id() 0
-static inline int up_smp_call_function(void)
+static inline int up_smp_call_function(void (*func)(void *), void *info)
{
return 0;
}
-#define smp_call_function(func,info,retry,wait) (up_smp_call_function())
+#define smp_call_function(func,info,retry,wait) \
+ (up_smp_call_function(func, info))
#define on_each_cpu(func,info,retry,wait) \
({ \
local_irq_disable(); \
@@ -107,6 +108,8 @@ static inline void smp_send_reschedule(i
local_irq_enable(); \
0; \
})
+#define smp_call_function_mask(mask,func,info,wait) \
+ (up_smp_call_function(func, info))

#endif /* !SMP */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/