Re: [patch 2.6.24-rc1] resource_len() utility function

From: Alan Cox
Date: Thu Oct 25 2007 - 08:30:55 EST


> So you'd suggest having search utilities (as with platform_bus)
> returning resource indices not resources?

That seems a bad idea to me

> Thing is, BARs are usually well defined, but when folk glue
> resources together they use whatever order is convenient on
> that particular platform. And different platforms can have
> different numbers and types of resources, etc.

Far better I think that pci_ functions that take BAR values end up as
wrappers of the form

pci_iomap(pdev, bar)
return dev_iomap_resource(&pdev->resource[bar]);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/