Re: [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict]

From: Thomas Renninger
Date: Thu Oct 25 2007 - 10:14:03 EST


On Thu, 2007-10-25 at 15:48 +0200, Jean Delvare wrote:
> Hi Andrew,
>
> On Wed, 24 Oct 2007 20:53:47 -0700, Andrew Morton wrote:
> > On Wed, 24 Oct 2007 16:33:07 +0200 Thomas Renninger <trenn@xxxxxxx> wrote:
> >
> > > From: Thomas Renninger <trenn@xxxxxxx>
> > > To: linux-acpi <linux-acpi@xxxxxxxxxxxxxxx>
> > > Cc: linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Jean Delvare <khali@xxxxxxxxxxxx>
> > > Reply-To: trenn@xxxxxxx
> > > Subject: [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict]
> > > Date: Wed, 24 Oct 2007 16:33:07 +0200
> > > Organization: Novell/SUSE
> > > X-Mailer: Evolution 2.8.2
> > >
> > > Export acpi_check_resource_conflict(), sometimes drivers already have
> > > a struct resource at hand so no need to use the wrappers to build a new
> > > one.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> > > ---
> >
> > The attributions on this are all mucked up.
> >
> > I _think_ it was written by Jean, in which case the changlog should
> > have had From:him right at the start to indicate this. And as you
> > were in the delivery path, it should have had your signoff.
> >
> > I'll make those changes - please let me know if I misguessed.
>
> You are correct, patches 3/5, 4/5 and 5/5 of this patchset were written
> by me (as in: I'm the one to blame if something breaks). I expected
> Thomas to add a From: header and add his own Signed-off-by line but
> instead he forwarded my mails directly. Thanks for fixing up the mess,
> we'll try to make it better next time.

As said, I wasn't sure against what I should base all this.
I would had cleaned it up, depending on what you told me. I also didn't
know about the From: tag if you send patches not from your own, the next
time...
Anyways, it's nice to see how things can move on right away without much
delay and discussion.

Thanks,

Thomas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/