RE: [2.6 patch] unexport tick_nohz_get_sleep_length

[Thomas Gleixner]

On Thu, 25 Oct 2007, Pallipadi, Venkatesh wrote:
> >On Wed, 24 Oct 2007, Adrian Bunk wrote:
> >
> >> This patch removes the unused 
> >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length).
> >> 
> >> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> >> 
> >> ---
> >> f7c83dfe117f4fd072b2506ae090e4145abda362 
> >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> >> index 10a1347..5997456 100644
> >> --- a/kernel/time/tick-sched.c
> >> +++ b/kernel/time/tick-sched.c
> >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void)
> >>  	return ts->sleep_length;
> >>  }
> >>  
> >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length);
> >> -
> >
> >Hmm, this was added to allow the cpuidle governers modular
> >build. Seems this was changed to compiled in only.
> >
> >Len, Venki, is this the final decision ?
> >
> 
> Yes. This was done recently for proper fallback to old ACPI policy in
> case CPUIDLE is not selected. With that being module, falling back to
> ACPI policy at run time makes things ugly.

Makes sense. I go ahead and nuke the export.

Thanks,

	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/