Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]

From: Roland Dreier
Date: Thu Oct 25 2007 - 19:38:53 EST


> > +static inline void *ERR_CAST(const void *ptr)
> > +{
> > + return (void *) ptr;
> > +}
>
> Just to nit, surely you don't need the cast inside the function. The
> casting happens at the call site between the argument and returned pointer.

The way it's written you kinda do, since it takes a const void * and
returns a plain void *. But I don't think that's the best way to
write it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/