Re: sg_next() for struct scatterlist is confusing

From: Haavard Skinnemoen
Date: Sat Oct 27 2007 - 12:34:12 EST


On Sat, 27 Oct 2007 07:39:40 -0400 (EDT)
"Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> wrote:

> note how the comment says that the next entry will "usually" be
> sg+1, "but" not if it's actually a pointer.
>
> however, as i read the code above, sg is *always* incremented before
> that testing. is that correct? am i just misreading something? or
> could the comment have been a bit clearer?

If it increments sg and finds a "chain" entry, it will follow it to the
next sg array instead of just returning it. Which makes sense because
the chain entry itself isn't a valid entry in the sg list.

HÃvard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/