Re: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S

From: Andi Kleen
Date: Sat Oct 27 2007 - 15:05:19 EST


Mathieu Desnoyers <compudj@xxxxxxxxxxxxxxxxxx> writes:

> We make sure that the thread flag read is coherent between our new test and the ALLWORK_MASK test by first saving it in a register used for both comparisons.
>

That doesn't make sense. If someone is setting those asynchronously you
can always race.

You should really just stop the process like ptrace does before changing
such things.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/