Re: [PATCH] proc_fs.h redux

[Jan Engelhardt]

On Oct 28 2007 10:34, Russell King wrote:
>On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote:
>> and forward declarations of
>> 
>> struct proc_dir_entry;
>> struct file_operations;
>> 
>> As a general rule, I think it better to use includes
>> than use naked forward declarations.
>
>If you go down that route, you end up with _lots_ of circular
>dependencies - header file X needs Y needs Z which needs X.  We've
>been there, several times.  It very quickly becomes quite
>unmaintainable - you end up with hard to predict behaviour from
>include files.
>
>The only realistic solution is to use forward declarations.

Especially because it reduces the amount of I/O that needs to be done.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/