Re: [PATCH] af_key: suppress a warning for 64k pages.

From: Stephen Rothwell
Date: Wed Oct 31 2007 - 00:34:40 EST


On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> I'm not so sure ifdef'ing things up all over the place is the way to
> solve this. It makes the code ultra ugly.

I agree.

> I think we should retain the check, but modify it so that GCC knows we
> understand that it's OK if it is always false. Perhaps a simple (u32)
> cast on the left branch of the comparison is sufficient?

Unfortunately, that does not suppress the warning (gcc is getting too
smart :-().

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature