Re: [PATCH] dump_stack on panic

From: Ingo Molnar
Date: Wed Oct 31 2007 - 06:18:24 EST



* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Wed, Oct 31, 2007 at 01:14:04AM +0100, Andi Kleen wrote:
> > One (mostly psychological, but still serious) problem is that stack
> > dumps make panics always look like kernel bugs. But there are panics
> > which are definitely not kernel bugs: like the popular cannot mount
> > root or machine checks or a couple of others.
>
> But that one really shouldn't be a panic anyway. The panic alone is
> psycologically bad enough for users. I think it would be best to have
> a simple scanf loop asking for another root device..

yep. Steve's patch looks good in any case.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/