Re: [PATCH] Unexport asm/user.h and linux/user.h

From: H. Peter Anvin
Date: Wed Oct 31 2007 - 17:10:39 EST


Kirill A. Shutemov wrote:
Do not export asm/user.h and linux/user.h during make headers_install.

Signed-off-by: Kirill A. Shutemov <k.shutemov@xxxxxxxxx>
Reviewed-By: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>

The version that is in there is currently broken from a user-space perspective (gdb expects u_ar0 to be struct user_regs_struct *, which it isn't for a bunch of the architectures defined); it *could* be argued the right thing is to fix it up since it *does* export an ABI
-- specifically, the format of a.out core dumps -- but it is probably easier to just axe it; userspace has had to deal with this issue on its own for a long time already.

As such,

Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/