Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

[Greg KH]

On Tue, Nov 06, 2007 at 10:36:58AM -0800, Badari Pulavarty wrote:
> On Tue, 2007-11-06 at 02:33 -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to
> > 
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz
> > 
> 
> > gregkh-driver-kset-convert-sys-devices-to-use-kset_create.patch
> 
> Above patch renamed devices_subsys to devices_kset to catch all users of
> the variable. Need fixes to vio.
> 
> 
> # make -j8 zImage
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CALL    scripts/checksyscalls.sh
> <stdin>:1389:2: warning: #warning syscall revokeat not implemented
> <stdin>:1393:2: warning: #warning syscall frevoke not implemented
>   CHK     include/linux/compile.h
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/powerpc/kernel/built-in.o(.toc+0x1548): undefined reference to
> `devices_subsys'
> make: *** [.tmp_vmlinux1] Error 1
> 
> 
> Here is the patch, Is this correct usage ?

Yes, but, what is this file doing mucking around in a "private" variable
to the driver core?  No wonder I never caught this, as it's one
reference away from being declared static.

Please fix this file up properly, like the comment in vio.c shows:
	 * XXX once vio_bus_type.devices is actually used as a kset in
	 * drivers/base/bus.c, this function should be removed in favor of
	 * "device_find(kobj_name, &vio_bus_type)"

The fact that this function works at all is so tenous and scary that I
would never trust it on a running system.  Let alone something so
"enterprise" as a pseries box...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/