Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

[Robert Hancock]

Tejun Heo wrote:
> Robert Hancock wrote:
> > Tejun Heo wrote:
> > > Robert Hancock wrote:
> > > > This fixes some problems with ATAPI devices on nForce4 controllers in
> > > > ADMA mode
> > > > on systems with memory located above 4GB. We need to delay setting
> > > > the 64-bit
> > > > DMA mask until the PRD table and padding buffer are allocated so that
> > > > they don't
> > > > get allocated above 4GB and break legacy mode (which is needed for ATAPI
> > > > devices).
> > > >
> > > > Signed-off-by: Robert Hancock <hancockr@xxxxxxx>
> > > applied to #tj-upstream-fixes.
> > I have a report that these patches crashed but the previous patch worked:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=351451
> >
> > So there may still be a problem here.
>
> Any progress?

It looks like the problem is that even though we set the DMA mask after 
we allocate the PRD and pad buffers, when the other port is set up, the 
DMA mask is already over 64-bit and so it allocates its buffers over 4GB 
and fails. I think we just need to explicitly set to 32-bit first, 
getting the reporter to try that one now.

--
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@xxxxxxxxxxxxx
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/