Re: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar forfixed-link property

[Joakim Tjernlund]

On Mon, 2007-11-26 at 17:29 +0300, Vitaly Bordug wrote:
> fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that
> not connected to the real MDIO bus.
> 
> Signed-off-by: Vitaly Bordug <vitb@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> 
> ---
> 
>  Documentation/powerpc/booting-without-of.txt |    3 +
>  arch/powerpc/sysdev/fsl_soc.c                |   56 ++++++++++++++++++--------
>  2 files changed, 42 insertions(+), 17 deletions(-)
> 
> 
> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
> index e9a3cb1..cf25070 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -1254,6 +1254,9 @@ platforms are moved over to use the flattened-device-tree model.
>        services interrupts for this device.
>      - phy-handle : The phandle for the PHY connected to this ethernet
>        controller.
> +    - fixed-link : <a b c> where a is emulated phy id - choose any,
> +      but unique to the all specified fixed-links, b is duplex - 0 half,
> +      1 full, c is link speed - d#10/d#100/d#1000.

Good work!
May I suggest adding a "d" to <a b c> where d is flow control - 0 no, 1 yes

flow control or not just popped up here today so I got a use for it.

 Jocke 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/