Re: [PATCH 23/27] x86: debugctlmsr kconfig

From: Denys Vlasenko
Date: Mon Nov 26 2007 - 17:52:50 EST


On Sunday 25 November 2007 23:51, Roland McGrath wrote:
> > Why is it defined in configuration system instead of some *.h file?
>
> That seems to be existing practice for this sort of thing.
> I just followed what I saw.

I think that if such conditional constants can be defined
in header files (IOW: if they are not used elsewhere in config system,
only in the C source code), they should not be put in config system.
Don't make it more complex than it needs to be.

Sam what do you think?
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/