Re: [PATCH 4/3] start the global /sbin/init with 0,0 special pids

[Eric W. Biederman]

Pavel Emelyanov <xemul@xxxxxxxxxx> writes:

> Eric W. Biederman wrote:
>> Oleg Nesterov <oleg@xxxxxxxxxx> writes:
>> 
>>> As Eric pointed out, there is no problem with init starting with sid == pgid
>>> == 0, and this was historical linux behavior changed in 2.6.18.
>>>
>>> Remove kernel_init()->__set_special_pids().
>>>
>>> This change and the previous change in daemonize() mean that /sbin/init does
>>> not need the special "session != 1" hack in sys_setsid() any longer. We can't
>>> remove this check yet, we should cleanup copy_process(CLONE_NEWPID) first, so
>>> update the comment only.
>> 
>> I guess that works.  As long as we get there.  We just need one more patch
>> in this series to fix the copy_process(CLONE_NEWPID).
>
> I hope this will NOT be the fix that creates the namespace's 
> init with the pid == 0 ;)

No just with session == pgrp == (unchanged and thus with vpid 0).

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/