Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

[Vegard Nossum]

Hi,

On Nov 28, 2007 7:51 AM, Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx> wrote:
> Vegard Nossum wrote:
> > +static int
> Not 'static bool'?
> > +page_is_tracked(struct page *page)
> Why not returning 'false' and 'true'?

Sorry, I am not used to using bool in C :-) I will change this if bool
is preferred in kernel code.

> > +static unsigned int
> > +opcode_get_size(const uint8_t *opcode)
> Are we not using 'u8' in the kernel?

Actually, I don't see any reason to use u8 when uint8_t is already
standard and used in other places in the kernel.

Thanks for the other comments! I will make the necessary changes for
the next version.

> cu
> Richard Knutsson

Vegard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/