Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/willstall forever

From: Steven Rostedt
Date: Wed Nov 28 2007 - 15:20:42 EST



On Wed, 28 Nov 2007, Russell King - ARM Linux wrote:

> On Wed, Nov 28, 2007 at 02:04:41PM -0500, Steven Rostedt wrote:
> > Thanks for the reply and this nice explanation.
> >
> > I'm taking this as a NACK.
> >
> > Daniel or Remy, could you find the offending users and make send patches
> > to fix them.
>
> Note that I'm not acking nor nacking the patch; I'm not involved with
> the RT stuff and I've never looked at the code, so I don't know what
> the implications of the patch itself are.

Understood. But I didn't know to pull it in or not. So I used your
explanation to NACK it myself. I don't understand all the intricacies of
the arm architecture. So while Thomas is out, I'm not pulling this in.

If he comes back and gives his ACK, I'll simply NACK my NACK ;-)

>
> I've merely explained the point of the simple irq handler.
>
> Maybe the simple irq handler should never have been something that got
> sucked into the generic IRQ stuff, but kept as something specific to
> Neponset.
>

This could also simply be unique to the interrupt threads (only in RT). So
perhaps the patch is OK.

Remy, sorry about this round-a-bout. But I don't have any of the hardware
that this affects, and I'm just being cautious.

Thanks,

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/