Re: [PATCH] kconfig: Make KCONFIG_ALLCONFIG work with randconfig.

[Paul Mundt]

On Wed, Nov 28, 2007 at 06:08:16PM +0100, Roman Zippel wrote:
> On Wed, 28 Nov 2007, Paul Mundt wrote:
> > While allyes/mod/noconfigs do seem to work fine with KCONFIG_ALLCONFIG
> > provisions, randconfig tramples all over the provided values at perhaps
> > not surprisingly, random.
> 
> Please be careful with such broad statements, there is only an issue with 
> choice values.
> 
Ok, I'll rephrase, '100% of the provided values I tested with were being
randomly clobbered'. Is that better? Broken is broken, whether it applies
to a small subset of symbols or not.

> > Debugging this a bit, there seemed to be two issues:
> > 
> > 	- SYMBOL_DEF and SYMBOL_DEF_USER overlap, which made
> > 	  def_sym->flags the same regardless of whether we came from an
> > 	  KCONFIG_ALLCONFIG path or not.
> 
> Look at how SYMBOL_DEF is used in confdata.c.
> 
Ah, ok. I was just trying to find something I could test that would be
different for the KCONFIG_ALLCONFIG path, but it seems like is_new is a
much cleaner solution for this, thanks for pointing it out!

Updated patch follows.

Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>

---

 scripts/kconfig/conf.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index a38787a..8d6f174 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -374,7 +374,8 @@ static int conf_choice(struct menu *menu)
 				continue;
 			break;
 		case set_random:
-			def = (random() % cnt) + 1;
+			if (is_new)
+				def = (random() % cnt) + 1;
 		case set_default:
 		case set_yes:
 		case set_mod:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/