Re: [PATCH 6/6] tick: add a missing dot in prink

From: Frans Pop
Date: Thu Nov 29 2007 - 03:58:49 EST


Li Zefan wrote:
> Add a missing '.' in prink information.
> - printk(" no tick device\n");
> + printk(" no tick device.\n");

I wonder if that is correct. CodingStyle says:
Chapter 13: Printing kernel messages
[...]
Kernel messages do not have to be terminated with a period.

I personally think that rule could be made a bit stricter as for example
dmesg output currently looks fairly inconsistent with some messages
terminated with a period while most messages are not and have been wondering
if I should file patches to _remove_ periods.

Maybe the rule should be changed to:
Kernel messages should not be terminated with a period, unless a single
message contains multiple sentences.
?

Cheers,
FJP
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/