Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

From: Andi Kleen
Date: Thu Nov 29 2007 - 05:30:08 EST


Vegard Nossum <vegard.nossum@xxxxxxxxx> writes:
>
> - We properly flush TLB entries that change. This used to not be the case, and so we

For low values of "properly" @)

> + pte = lookup_address(addr);
> + change_page_attr(page, 1, __pgprot(pte->pte_low | _PAGE_VISIBLE));
> + __flush_tlb_one(addr);

That's not enough, you need to flush all CPUs.

Also when you don't call global_flush_tlb() eventually because c_p_a() will leak flush
objects over time.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/