Re: Trailing periods in kernel messages
From: Li Zefan
Date: Thu Nov 29 2007 - 20:57:17 EST
Joe Perches wrote:
> On Fri, 2007-11-30 at 09:12 +0800, Li Zefan wrote:
>> Just a roughly grep:
>> # grep -r -P --include=*.[ch] 'printk.*\.\\n' * | wc -l
>> 6025
>> # grep -r -P --include=*.[ch] '\.\\n' * | wc -l
>> 12723
>
> Inequivalent.
>
> Try:
> grep -rP --include=*.[ch] 'printk.*\.\\n' * | wc -l
> and
> grep -rp --include=*.[ch] 'printk.*[^\.]\\n' * | wc -l
>
> 6k/38k
>
My 2nd grep finds out how many strings are terminated with '.'.
Those strings may finally pass to prink().
So it doesn't deserve the effort to eliminate these periods, isn't it?
Or we can add a check to checkpatch.pl to prevent new ones.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/