Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch

[Jaswinder Singh]

On 11/30/07, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:
> On Fri, Nov 30, 2007 at 04:33:19PM +0530, Jaswinder Singh wrote:
> > This patch fixes s390 dependency for x86
> >
> > Signed-off-by: Jaswinder Singh <jaswinderlinux@xxxxxxxxx>
>
> Deleting random parts of the kernel tree is actually not
> supported.
>

I agree with you. I just did this to same some space because I keep
many kernel trees.

But i am curious if other arch do not depends on x86 then s390 ?

> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > index 1330061..b699ed5 100644
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -537,4 +537,6 @@ source "security/Kconfig"
> >
> >  source "crypto/Kconfig"
> >
> > +source "arch/s390/crypto/Kconfig"
> > +
>
> With this there's no dependency on CRYPTO_HW anymore.
>

Anyhow "if CRYPTO_HW" is not working in drivers/crypto/Kconfig

have you tested this patch on S390. Is this giving errors ?

And you can also add depends with CRYPTO_HW in arch/s390/crypto/Kconfig

Thank you,

Jaswinder Singh.


> > +#ifdef CONFIG_S390
> >  #include "../arch/s390/appldata/appldata.h"
> > +#endif
>
> This include can go away.
>
> Since this pops up again and again we'll come up with a patch to fix this.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/