Re: [PATCH] ipwireless_cs driver for 4G PC Card

[Robert P. J. Day]

On Fri, 30 Nov 2007, David Sterba wrote:

...
>  drivers/char/pcmcia/Kconfig                        |    8
>  drivers/char/pcmcia/Makefile                       |    4
>  drivers/char/pcmcia/ipwireless_cs_hardware.c       | 1728 +++++++++++++++++++++
>  drivers/char/pcmcia/ipwireless_cs_hardware.h       |   63
>  drivers/char/pcmcia/ipwireless_cs_main.c           |  479 +++++
>  drivers/char/pcmcia/ipwireless_cs_main.h           |   70
>  drivers/char/pcmcia/ipwireless_cs_network.c        |  496 ++++++
>  drivers/char/pcmcia/ipwireless_cs_network.h        |   54
>  drivers/char/pcmcia/ipwireless_cs_setup_protocol.h |  108 +
>  drivers/char/pcmcia/ipwireless_cs_tty.c            |  779 +++++++++
>  drivers/char/pcmcia/ipwireless_cs_tty.h            |   48
>  12 files changed, 3845 insertions(+)

might it not make more sense to put all of that into a new
subdirectory, say, /drivers/char/pcmcia/ipwireless_cs?  that way, it's
more modular and it will keep that higher-level directory from
potentially getting cluttered with even more drivers.  and it would
let you drop the pointless "ipwireless_cs_" prefix from all of those
files as well.

rday


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/