Re: m68k build failure

From: Pierre Ossman
Date: Sat Dec 01 2007 - 15:56:20 EST


On Wed, 28 Nov 2007 13:34:02 +0100 (CET)
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> On Wed, 28 Nov 2007, Pierre Ossman wrote:
> >
> > Is there no directive we can stick in there that forces a reasonable alignment (e.g. alignment == sizeof(type)) independently of arch?
>
> We could use something like is used for compat_*.
> E.g. compare compat_s64 in <asm/compat.h> for x86 and powerpc.
>

Yeah, that could work. Have a header with stuff like this:

typedef u16 __attribute__((aligned(2))) aligned_u16;
typedef u32 __attribute__((aligned(4))) aligned_u32;

and let all structures in mod_devicetable.h use those types.

Now does anyone have the time to code and test this?

Rgds
Pierre

Attachment: signature.asc
Description: PGP signature