On Sat, 2007-12-01 at 01:33 +0100, Rene Herman wrote:On 01-12-07 00:52, Bjorn Helgaas wrote:
No it is not. It is just another optimization I saw while going throughI agree this is probably safe in the current implementation.<shrug>
However, I think the current implementation is just broken because
we can't really handle hotplug of ACPI devices. Specifically, I think
the first TBD in acpi_bus_check_device() should be fleshed out so it
does something like pnpacpi_add_device().
So my dissenting opinion is that this patch would just get reverted
soon anyway when somebody finishes implementing ACPI hotplug, and
therefore it's not worth doing.
The PnPBIOS bits should still be fine at least I guess. And, it would seem this is rather essential to Thomas' efforts of making this stuff dynamic in the first place anyway.
these code parts...