Re: [RESEND] [PATCH] RTC: assure proper memory ordering withrespect to RTC_DEV_BUSY flag (was Re: RTC: convert mutex to bitfield)

From: Alessandro Zummo
Date: Sun Dec 02 2007 - 17:16:28 EST


On Sun, 2 Dec 2007 23:00:04 +0100 (CET)
Jiri Kosina <jkosina@xxxxxxx> wrote:

> [ nobody seems to have picked this up, resending. This is a fix for
> commit 8853c202b4 in Linus' tree ]
>
> From: Jiri Kosina <jkosina@xxxxxxx>
>
> RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag
>
> We must make sure that the RTC_DEV_BUSY flag has proper lock semantics,
> i.e. that the RTC_DEV_BUSY stores clearing the flag don't get reordered
> before the preceeding stores and loads and vice versa.
>
> Spotted by Nick Piggin.
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

missed it, sorry.


Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/