Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes

[Richard Knutsson]

Hans Verkuil wrote:
> On Sunday 02 December 2007 18:46, Richard Knutsson wrote:
>   
> > Fix "warning: Using plain integer as NULL pointer".
> >     
>
> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
>
>   
> > Remove a gcc-2.95 requirement.
> >     
>
> NACK! The main v4l-dvb repository that contains this driver can also be 
> compiled on older systems. I'd like to keep the option that the driver 
> can be compiled with an older gcc version, unless Mauro thinks 
> otherwise. Other than the removal of one comment and one space there 
> are no other benefits of this change, so I'd prefer to keep it.
>
>   
Oh alright, thought it was just a leftover since the support for the 
2.95 ended.
Maybe add something to the text to let others know the status? (Since I 
found it by doing a 'grep' for "gcc 2.95"'s...)
> > Convert 'x < y ? x : y' to use min() instead.
> >     
>
> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
>
> Thanks,
>
> 	Hans
>
>   
Thanks for the fast turnaround
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/